Remove fast table search by default

[jecisc]

It often happens is a table or list has the focus that we start to type and a search popover appears but it filters nothing. And in multiple UIs, we have a filter done with an input field under the list and both are overlapping and it becomes really confusing.

I propose to disable the FastTable search by default and I also remove a dead method

[Ducasse]

@jecisc could we rename the method disableFunction into disableSearch? Because disableFunction is kind of obscure, don't think?

[jecisc]

It is call function because it can be more than a search. But the search function is the one enabled by default

[Ducasse]

Looks like a not so good name to me.

[Ducasse]

/home/runner/.smalltalkCI/_builds/TravisCI.image
Pharo13.0.0SNAPSHOT
Build information: Pharo-13.0.0+SNAPSHOT.build.87.sha.0ac6afe9a01de2cd856af00b775bf8b48d7a329a (64 Bit)

 > Done in 1.000ms.
Loading project...
Syntax Error on line 2: 'Undeclared variable'
=============================================
1: #( 'BaselineOfSpec2' 'BaselineOfSpecCore' ) do: [ :each | 
2:  (RPackageOrganizer default packageNamed: each ifAbsent: [ nil ]) 
    _^_
3:      ifNotNil: [ :aPackage | aPackage removeFromSystem ] ]
CodeError:OCUndeclaredVariableNotice UndefinedObject>>#DoIt 62:Undeclared variable->RPackageOrganizer
OCUndeclaredVariableNotice(RBNotice)>>signalError
OpalCompiler>>checkNotice:
[ :n |
            | check |
            check := self checkNotice: n.
            check ifNil: [ ^ ast ].
            check ifFalse: [
                ast := nil.

[Ducasse]

SpListSearchTest
 ✗ #testSearchWithFunction (78ms)
 ✗ #testTypePerformsSearch (43ms)
 ✗ #testSearchWithFunction (39ms)
 ✗ #testTypePerformsSearch (30ms)

SpTableCommonPropertiestTest
 ✗ #testTypePerformsSearch (38ms)
 ✗ #testTypePerformsSearch (41ms)

SpTableSearchTest
 ✗ #testSearchWithFunction (54ms)
 ✗ #testTypePerformsSearch (26ms)
 ✗ #testSearchWithFunction (52ms)
 ✗ #testTypePerformsSearch (36ms)

SpListCommonPropertiestTest
 ✗ #testTypePerformsSearch (55ms)
 ✗ #testTypePerformsSearch (55ms)

[demarey]

Looks like a not so good name to me.

+1

[jecisc]

Maybe we could update the name in FastTable, but here I am updating a usage of FastTable. FastTable is in Morphic so I cannot update it in this PR

[Ducasse]

Sure we should do that in another PR.

[Ducasse]

ReleaseTest
 ✗ #testUndeclared (151ms)

  Executed 131 Tests with 1 Failures and 0 Errors in 61.36s.

To reproduce the failed build locally, download smalltalkCI, and try to run something like:

[Ducasse]

I'm confused

###########
# Summary #
###########

SpListSearchTest
 ✗ #testSearchWithFunction (78ms)
 ✗ #testTypePerformsSearch (43ms)
 ✗ #testSearchWithFunction (39ms)
 ✗ #testTypePerformsSearch (30ms)

SpTableCommonPropertiestTest
 ✗ #testTypePerformsSearch (38ms)
 ✗ #testTypePerformsSearch (41ms)

SpTableSearchTest
 ✗ #testSearchWithFunction (54ms)
 ✗ #testTypePerformsSearch (26ms)
 ✗ #testSearchWithFunction (52ms)
 ✗ #testTypePerformsSearch (36ms)

SpListCommonPropertiestTest
 ✗ #testTypePerformsSearch (55ms)
 ✗ #testTypePerformsSearch (55ms)

  Executed 1545 Tests with 12 Failures and 0 Errors in 45.56s.

To reproduce the failed build locally, download smalltalkCI, and try to run something like: