search

pharo-spec / Spec

Spec is a framework in Pharo for describing user interfaces.
MIT License
62 stars 65 forks source link

Enable specification of a comparison strategy to compare list items #1573

Closed hernanmd closed 4 months ago

hernanmd commented 4 months ago

This change allows for custom comparison strategies to SpCollectionListModel. The main changes are:

  1. Added comparisonStrategy instance variable with getter and setter.
  2. Changed indexOf:ifAbsent: method to use the comparison strategy.
  3. Initialized comparisonStrategy with identity comparison in the initialize method.
hernanmd commented 4 months ago

@jecisc this is what you need to get the CI green again :)

jecisc commented 4 months ago

This one has the same problem as a PR done by esteban :( I don't know why but the produced image has methods without protocol which should never happen. And I have a really hard time to debug the problem.

It's probably not caused by your code directly, but it probably causes something that ends up creating the problem