search

pharo-spec / Spec

Spec is a framework in Pharo for describing user interfaces.
MIT License
62 stars 65 forks source link

Fix slider #1619

Closed tinchodias closed 1 month ago

tinchodias commented 1 month ago

Partially fixes #1613

astares commented 1 month ago

Will this also fix https://github.com/pharo-spec/Spec/issues/1410 and https://github.com/pharo-spec/Spec/issues/899 (which is related to SpSliderPresenter as well)?

tinchodias commented 1 month ago

Yes, thank you for the references @astares. I commented in both issues now. I can't close them, don't have permissions.

astares commented 1 month ago

@tinchodias I checked in a fresh P13 image as of a few minutes ago:

Pharo13.0.0SNAPSHOT Build information: Pharo-13.0.0+SNAPSHOT.build.292.sha.4b69f175d6873a03ffbad68a892e671a6ad69ef1 (64 Bit)

and it is not fixed there. But the code is not in yet.

I think the merge in the Spec repo does not yet trigger an image build to include the Pharo13 branch again into standard image. We have to wait for a merge in the standard repo so that the image build is triggered.

If you have the code loaded you can try with

SpDemo open

and see if the slider on "Forms" dialog with the "Scale:" label behaves correctly.

tinchodias commented 1 month ago

I've worked on P12(*) but you can see it working:

Oct-14-2024 14-13-14

(*): More exactly: Pharo 12.0.0 Build information: Pharo-12.0.0+SNAPSHOT.build.1530.sha.b368d31b34edb6e488d36358613c2eae00c2f495 (64 Bit)

tinchodias commented 1 month ago

For the record: I just realized I didn't mention that @tesonep worked on these changes. We spotted together the issues in a pair-programming session, and performed the main fixes. Then I refactored and fixed some more, before creating the PR. Cheers