pharo-spec / Spec

Spec is a framework in Pharo for describing user interfaces.
MIT License
62 stars 65 forks source link

Set enablement of button in SpCommand>>#configureAsButtonOfClass: #1621

Closed koendehondt closed 1 month ago

koendehondt commented 1 month ago

This PR is for Pharo 12.

It fixes the missing enablement in SpCommand>>#configureAsButtonOfClass:. See https://github.com/pharo-spec/Spec/issues/1618.

Ducasse commented 1 month ago

We should probably push it also to P13

koendehondt commented 1 month ago

I will create a PR for Pharo 13.

On 9 Oct 2024, at 08:20, StéphaneDucasse @.***> wrote:

We should probably push it also to P13

— Reply to this email directly, view it on GitHub https://github.com/pharo-spec/Spec/pull/1621#issuecomment-2401408996, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFX457FJMGSZUTJOO72X2DZ2TDJFAVCNFSM6AAAAABPS64E42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBRGQYDQOJZGY. You are receiving this because you authored the thread.

koendehondt commented 1 month ago

Here you go: https://github.com/pharo-spec/Spec/pull/1622

estebanlm commented 1 month ago

for pharo12, merge the pr is not enough, but I can't do it today.

Ducasse commented 1 month ago

Ok :) No stress Now I have to read the new chapters.

estebanlm commented 1 month ago

here you go: https://github.com/pharo-project/pharo/pull/17245

Ducasse commented 1 month ago

Cool