Manage packages starting with digits

pharo-vcs / iceberg

Iceberg is the main toolset for handling VCS in Pharo.

MIT License

133 stars 84 forks source link

Manage packages starting with digits #1062

Open jecisc opened 5 years ago

jecisc commented 5 years ago

We should either:

Allow to commit packages starting with a digit and manage them
Forbid to commit a package starting with a digit

jecisc commented 5 years ago

We should also do the same thing for packages with symbols at the beginning. Because in Pharo we have for example _UnpackagedPackage

hogoww commented 5 years ago

This modification would be in:

IceLibgitTonelWriter >> isValidPackage: aFileReference

^ aFileReference basename first isLetter

But I assume there's real reasons to this. Another solution would be to add a popup/warning/whatever to say that even if pharo accepts it, Iceberg can't.

Also, Iceberg did commit my code, and upload it on github well. It just doesn't show me the packages in Iceberg interface, and the clone doesn't work.