search

pharo-vcs / iceberg

Iceberg is the main toolset for handling VCS in Pharo.
MIT License
134 stars 85 forks source link

DNU for viewing pull request #1113

Open astares opened 5 years ago

astares commented 5 years ago

Open iceberg, select a repository and click on "Extra" -> "Review pull request"

IceTipRepositoriesBrowser(Object)>>doesNotUnderstand: #viewPullRequest: IceTipGitHubOpenPullRequestBrowserCommand>>execute IceTipRepositoryListContext(CmdToolContext)>>executeCommand:by: [ self prepareCommandForExecution. context executeCommand: command by: self. self applyCommandResult ] in CmdCommandActivator>>executeCommand in Block: [ self prepareCommandForExecution.... BlockClosure>>on:do: CmdCommandActivator>>executeCommand [ | selArgCount | "show cursor in case item opens a new MVC window" (selArgCount := selector numArgs) = 0 ifTrue: [ target perform: selector ] ifFalse: [ selArgCount = arguments size ifTrue: [ target perform: selector withArguments: arguments ] ifFalse: [ target perform: selector withArguments: (arguments copyWith: evt) ] ]. self showShortcut. self changed ] in ToggleMenuItemMorph(MenuItemMorph)>>invokeWithEvent: in Block: [ | selArgCount |... BlockClosure>>ensure: CursorWithMask(Cursor)>>showWhile: ToggleMenuItemMorph(MenuItemMorph)>>invokeWithEvent: ToggleMenuItemMorph(MenuItemMorph)>>mouseUp: ToggleMenuItemMorph(MenuItemMorph)>>handleMouseUp: MouseButtonEvent>>sentTo: ToggleMenuItemMorph(Morph)>>handleEvent: MorphicEventDispatcher>>dispatchDefault:with: MorphicEventDispatcher>>handleMouseUp: MouseButtonEvent>>sentTo: [ ^ anEvent sentTo: self ] in MorphicEventDispatcher>>dispatchEvent:with: in Block: [ ^ anEvent sentTo: self ] BlockClosure>>ensure: MorphicEventDispatcher>>dispatchEvent:with: ToggleMenuItemMorph(Morph)>>processEvent:using: MorphicEventDispatcher>>dispatchDefault:with: MorphicEventDispatcher>>handleMouseUp: MouseButtonEvent>>sentTo: [ ^ anEvent sentTo: self ] in MorphicEventDispatcher>>dispatchEvent:with: in Block: [ ^ anEvent sentTo: self ] BlockClosure>>ensure: MorphicEventDispatcher>>dispatchEvent:with: MenuMorph(Morph)>>processEvent:using: MenuMorph(Morph)>>processEvent: MenuMorph>>handleFocusEvent:

jecisc commented 5 years ago

The problem is that the menu should not be here.

To good entry point is under GitHub -> View PR

We should remove this menu entry in the extra menu.

SergeStinckwich commented 4 years ago

This is no more "Extra" -> "Review pull request" menu. Can we close this issue?