pharo-vcs / iceberg

Iceberg is the main toolset for handling VCS in Pharo.
MIT License
134 stars 85 forks source link

loading a private github error fails on "Not Found" #1167

Open amiracam opened 5 years ago

amiracam commented 5 years ago

First of all , I can't seem to find a way of copying the stack in Pharo

The IceGitHubAPI attempts to #get 'repos/amiracam/PrivateRepoPharoTest' which fails with "a ZnResponse(404 Not Found application/json;charset=utf-8 88B)" the actual repo url is: https://github.com/amiracam/PrivateRepoPharoTest

I do have my plain text auth credentials registered with Pharo the IceGitHubAPI instance however has credentials set to nil and isAnonymous set to true, not sure of the design but intuitively you would think that to access a private repo one would indeed need credentials and is anonymous should also probably be set to false

modifying the getGitHubRepository to:

getGitHubRepository [ ^ IceGitHubAPI new "beAnonymous;" getRepository: self userName project: self projectName ] on: LGitNoCredentialsProvided do: [ ^ nil ]

i.e. by default githubAPI will use credentials

this got me past the error , so perhaps some sort of checkbox indicating whether the repository being cloned is "owned" by the current user or whether its "private" which alludes to ownership may be a reasonable fix but I will leave that to the creators.

hogoww commented 5 years ago

Similar issue #1184