search

pharo-vcs / iceberg

Iceberg is the main toolset for handling VCS in Pharo.
MIT License
134 stars 85 forks source link

IceBranchNotFound for "View Pull Requests" functionality in Iceberg #1380

Open astares opened 4 years ago

astares commented 4 years ago

Iceberg in latest Pharo 9:

Image

D:\WORLD\Pharo\LauncherImages\10-0-2-Bootstrap4\10-0-2-Bootstrap4.image Pharo9.0.0 Build information: Pharo-9.0.0+build.494.sha.16ee422f2e5531b67a1745b595d1c5fddf54f9c0 (64 Bit) Unnamed

Scenario:

  1. Facundo from Argentina (who is working on Ubuntu) created a PR for my https://github.com/astares/Seaside-Bootstrap4 project. So basically he forked my repo on GitHub, fixed the issue #2 of this repo and used the GitHub UI to create a PR

  2. On my side (working on Windows, no SSH but regular HTTPS authentications in Iceberg) I took a recent image, loaded my Bootstrap4 project and then used Iceberg with "GitHub" -> "View Pull Requests" and then double clicking the pull request I get an error

image

astares commented 4 years ago

I can only guess but maybe it is because Iceberg assumes the user to work with SSH being setup.

But I prefer to authenticate manually when I interact with GitHub.