search

pharo-vcs / iceberg

Iceberg is the main toolset for handling VCS in Pharo.
MIT License
134 stars 85 forks source link

IceTip* MUST NOT refer to UIManager #1761

Open Ducasse opened 1 year ago

Ducasse commented 1 year ago

But request the application for a dialog eg.

diff

    ^ diffModel ifNil: [ 
          | diff |
          UIManager default
              informUser: 'Calculating diff'
              during: [ diff := self calculateDiff ].
          diffModel := IceTipCommitDiffModel
                           repositoryModel: self repositoryModel
                           on: diff ]

=>

diff

    ^ diffModel ifNil: [ 
          | diff |
          self application 
              informUser: 'Calculating diff'
              during: [ diff := self calculateDiff ].
          diffModel := IceTipCommitDiffModel
                           repositoryModel: self repositoryModel
                           on: diff ]
Ducasse commented 1 year ago

waiting for a PR to be integrated in Spec.

Ducasse commented 1 year ago

I started to work on this.

Ducasse commented 1 year ago

https://github.com/pharo-vcs/iceberg/pull/1769