Instabilitity probably due to inform:during:

pharo-vcs / iceberg

Iceberg is the main toolset for handling VCS in Pharo.

MIT License

134 stars 85 forks source link

Instabilitity probably due to inform:during: #1780

Closed Ducasse closed 8 months ago

Ducasse commented 11 months ago

I get diffPanel is nil in subclasses

IceTipPreviewBrowser>>initializePresenters

    self application 
        informUser: 'Calculating diff'
        during: [ diffPanel := self instantiate: IceTipDiffPanel on: self model diff ].
    actionPanel := self newButtonBar.
    actionPanel add: (button := self newActionButton)

And I suspect the during: to not being executed at the right moment.

estebanlm commented 8 months ago

we reverted the change so now this does not happens anymore