Update users of IceTipStandardAction to use #newXAction + #executeWithContext: pattern (fixes #1779)

daniels220 commented 11 months ago

Fixes nil DNU #application errors for package reload/remove/unload, tag delete, and method version load (fixes #1779).

Also remove extraneous IceRepositoryModified when the action already has #onSuccessRepositoryModified.
Add missing ^return in IceTipVersionHistoryModel>>retrieveHistory.
Remove IceTipStandardAction>>execute: as execution without a context will ~always fail and the pattern is to assign the action first, then the context at time of execution. No references remain in Iceberg packages, and in fact all remaining references are self-sends, so clearly aren't sent to IceTipStandardAction.
Consistent classification for #execute methods in IceTipCommand hierarchy

Ducasse commented 11 months ago

Thanks for the PR.

guillep commented 10 months ago

Thanks!

guillep commented 10 months ago

Oh there are conflicts, I'll push them to the end of the queue

guillep commented 10 months ago

Hi @daniels220 I resolved the conflict locally but it seems you did not give rights to push to your branch so I cannot fix it :)

daniels220 commented 10 months ago

Ah, I didn't realize you were going to resolve them, so I went ahead and did so. No actual conflicts—doing a back-merge in Iceberg didn't flag anything—just Git not being very syntax-aware.

guillep commented 10 months ago

Ah, I didn't realize you were going to resolve them, so I went ahead and did so. No actual conflicts—doing a back-merge in Iceberg didn't flag anything—just Git not being very syntax-aware.

Sure no problem!

Thanks again!

pharo-vcs / iceberg

Update users of IceTipStandardAction to use #newXAction + #executeWithContext: pattern (fixes #1779) #1781