search

pharo-vcs / iceberg

Iceberg is the main toolset for handling VCS in Pharo.
MIT License
134 stars 85 forks source link

Push does not push tags other than in head commit #1812

Open Ducasse opened 8 months ago

Ducasse commented 8 months ago

self tags is empty in the following method because it returns the tag of the commit which is a new commit.

IceGitLocalBranch>>pushTagsToRemote: aRemote gitRemote: gitRemote progress: pushProgress

    self tags do: [ :tag | 
        self 
            pushTag: tag 
            toRemote: aRemote 
            gitRemote: gitRemote 
            progress: pushProgress ]

Here is a possible fix 

IceGitLocalBranch>>pushTagsToRemote: aRemote gitRemote: gitRemote progress: pushProgress

    self repository tags do: [ :tag | 
        self 
            pushTag: tag 
            toRemote: aRemote 
            gitRemote: gitRemote 
            progress: pushProgress ]
tinchodias commented 8 months ago

the possible fix makes sense to me