Push window does not honor selected remote

[guillep]

I click on push, the window is opened with a default remote selected (which is ok to me, I want to push there)

I click on Push, and!

I have a permission denied. Of course, It tried to push to another remote and not the one selected!

Moreover, if I change remote (select the second remote, then select back the first one in the list), everything is ok.

Finally, the list of commits shown to push are not the ones to push to the selected remote but to the other one!

It's like the shown remote is not the selected remote.

[Ducasse]

This is the same bug we faced with Quentin Moutté

[guillep]

I chased this down a bit.

The problem is that inside the drop down, the dropdown items are all equal (they respond true to =) systematically. This seems to happen because the drop list items have not their display block set, so they return an asString of the model.

This means there are two issues:

• how comes the drop down shows a description if the display block is not set???
• selection never works by default if the prinstring is not correctly set. We should probably use identity comparisons?

[guillep]

The answer to the first question is that it is the droplist that has the display block

initializePresenters

    remoteList := self newDropList
        display: [ :each | each shortDescription ];
        yourself.
...

So, is the display block in the item required/useful?

[guillep]

Fixed in P12 and P13 in Spec