pharo-vcs / iceberg

Iceberg is the main toolset for handling VCS in Pharo.
MIT License
134 stars 85 forks source link

Add method history browser context menu item for browsing the selected commit in the repository browser #1846

Closed Rinzwind closed 3 weeks ago

Rinzwind commented 1 month ago

When looking at the history of a method, I often want to see the wider context: what else was changed in the same commit, and what commits were done before and after. To support that, this pull request extends the commit list context menu in the window showing the history of a method with a menu item ‘Browse commit’ that opens a repository browser on the corresponding repository and selects the same commit. The first of the following two screenshots shows an example of using the menu item and the second one shows the repository browser that is opened:

Rinzwind commented 1 month ago

The speed of browsing larger repositories, such as the ‘pharo’ repository itself, needs some improvement for this feature to be (more) useful though.

hemalvarambhia commented 1 month ago

Is there a way to get the checks green? Why are they red?

Rinzwind commented 1 month ago

I didn’t investigate beyond determining that the failing checks are probably not related to the changes in this pull request: for the run of ‘Iceberg-Pharo-Integration’, the test that failed also failed in the corresponding run for commit bd041b9, and for the run of ‘Complete Test’, the file deletion error in the Windows job likewise affected the Windows job in the corresponding run for commit bd041b9 (though in the latter it occurred while testing whereas in the former it occurred while loading).

Ducasse commented 1 month ago

There is this test failing

testNoEquivalentSuperclassMethods apparently it is unique.

Can you have a look? Else I will merge and I will fix it.

Rinzwind commented 1 month ago

That test is the one that also failed in the corresponding run for commit bd041b9 so I don’t think that’s related to the changes in this pull request.