pharo-vcs / iceberg

Iceberg is the main toolset for handling VCS in Pharo.
MIT License
133 stars 84 forks source link

LGit_GIT_ERROR: error authenticating: no auth sock variable loading a Tonel based baseline dependency in smalltalkCI #643

Closed gcotelli closed 6 years ago

gcotelli commented 6 years ago

smalltalkCI now supports the tonel file format and the iceberg-metacello integration is not disabled anymore.

Loading a project depending in another project both in Tonel format gives this error on Pharo 7:

LGitReturnCodeEnum>>handleLGitReturnCode
LGitRepository(LGitExternalObject)>>withReturnHandlerDo:
LGitRepository>>clone:options:to:
LGitRepository>>clone:options:
IceGitScpRemote(IceGitRemote)>>cloneIn:subdirectory:
IceRepositoryCreator>>cloneRepository

Checkout https://travis-ci.org/ba-st/Boardwalk/jobs/368090233

In Pharo 6.1 is working Ok.

estebanlm commented 6 years ago

the error is this one:

LGit_GIT_ERROR: error authenticating: no auth sock variable.

ant technically is not an iceberg problem either :) it means you do not have SSH agent in your test system.

but... metacello integration should have fallbacked to HTTPS (instead SSH). And that's a bug :)

estebanlm commented 6 years ago

should be fixed on 0.7.3

gcotelli commented 6 years ago

This is supposed to be fixed. But it's still failing with the latest pharo 7 version. Checkout this build from today: https://travis-ci.org/ba-st/Willow/jobs/373448344

guillep commented 6 years ago

Ok, I assume the problem is that Iceberg is not catching the "absence of ssh agent" error. I'll try to get a way to reproduce it in a test

guillep commented 6 years ago

Ok, it was apparently that. In #752 I've introduced:

gcotelli commented 6 years ago

Thanks Guille, when this is merged in Pharo I can test easily my projects in smalltalkCI/travis so we can know if it's working.

On Wed, May 2, 2018 at 9:45 AM Guille Polito notifications@github.com wrote:

Ok, it was apparently that. In #752 https://github.com/pharo-vcs/iceberg/issues/752 I've introduced:

  • new metacello integration tests for it that run on the CI
  • some architectural renraku rules to validate that we are correctly handling errors
  • plus a pass on iceberg to check all violated rules

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pharo-vcs/iceberg/issues/643#issuecomment-385964985, or mute the thread https://github.com/notifications/unsubscribe-auth/ACAleHq7iptZ0OxQcLoDb4SIG9bf6Ap8ks5tuapQgaJpZM4TZ4B6 .

jecisc commented 6 years ago

What is really weird is that it works in Pharo 6.1 but not 7.

I have the same problem with one of my project.

guillep commented 6 years ago

@gcotelli I'd like to build a more interesting integration test for it in the CI. Can you tell me if this happens only for tonel projects or also for filetree? I'd say it should happen for both...

@jecisc Iceberg - metacello integration in pharo 6 is disabled by default :)

gcotelli commented 6 years ago

I don't know because all the projects we have are now in tonel format and in the meantime two things changed: to support tonel format smalltalkCI was changed to not disable the Iceberg-Metacello integration anymore, and Iceberg changed too, so I can't tell if with filetree repos the same error happens. I suppose it should happen for both.

On Wed, May 2, 2018 at 10:12 AM Guille Polito notifications@github.com wrote:

@gcotelli https://github.com/gcotelli I'd like to build a more interesting integration test for it in the CI. Can you tell me if this happens only for tonel projects or also for filetree? I'd say it should happen for both...

@jecisc https://github.com/jecisc Iceberg - metacello integration in pharo 6 is disabled by default :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pharo-vcs/iceberg/issues/643#issuecomment-385972867, or mute the thread https://github.com/notifications/unsubscribe-auth/ACAleNIZyMAr7pM_eZ9_UicpNsLn-M2Sks5tubDAgaJpZM4TZ4B6 .

jecisc commented 6 years ago

It now works:

https://travis-ci.org/TelescopeSt/Telescope/jobs/373994423

guillep commented 6 years ago

@gcotelli can you confirm if this works on your side too? If so, I'll close this issue :)

gcotelli commented 6 years ago

It works now. Thanks.

On Thu, May 3, 2018 at 1:00 PM Guille Polito notifications@github.com wrote:

@gcotelli https://github.com/gcotelli can you confirm if this works on your side too? If so, I'll close this issue :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pharo-vcs/iceberg/issues/643#issuecomment-386346079, or mute the thread https://github.com/notifications/unsubscribe-auth/ACAleCoSvOE3-kLzjMe6yoUpV-XdHI0Bks5tuymHgaJpZM4TZ4B6 .

guillep commented 6 years ago

Nice! Thanks