search

pharo-vcs / tonel

MIT License
32 stars 26 forks source link

Conversion from filetree to tonel: package wrongly converted #74

Closed jbrichau closed 3 years ago

jbrichau commented 5 years ago

When trying to convert Seaside (https://github.com/SeasideSt/Seaside) sources to tonel, the converted repository is not correct. For example, the Seaside-Tests-Component cannot be found. I notice this package has no classes directly defined in Seaside-Tests-Component but only in subcategories. There are, however, package extensions defined in Seaside-Tests-Component.

The converter created a package Seaside-Tests-Component-Stubs rather than Seaside-Tests-Component. See https://github.com/SeasideSt/Seaside/tree/master-tonel/repository

To test:

astares commented 5 years ago

This one seems to be problematic for other issues as well https://github.com/astares/Seaside-Bootstrap/issues/9

bencoman commented 5 years ago

Has the fix been integrated into Pharo 8?

estebanlm commented 5 years ago

I have no idea :) @guillep this was in 1.6.0?

guillep commented 5 years ago

No it was not because nobody integrated the PR. Iceberg's 1.6.0 had only what was already integrated. I'll integrate it now and make it for 1.7.0

jbrichau commented 3 years ago

This issue can be closed. I have done the conversion to tonel again in Pharo9 for the Seaside repository and it seems to be all OK. At the very least, this issue is no longer there.