Missing Icons

[bhenstra]

I run Debian Sid. I did install the following packages: meson valac debhelper golang-gir-gobject-2.0-dev golang-gir-glib-2.0-dev libgee-0.8-dev libgranite-dev libxml2-dev libgtk-3-dev libhandy-1-dev

I did run sudo ./app install for a aystem wide install.

I am missing the following icons: Pencil Tool Crop Image

Please see the screenshot: Missing-Icons.jpg

$ uname -a Linux sonic 6.1.0-4-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.11-1 (2023-02-09) x86_64 GNU/Linux

$ /usr/bin/com.github.phase1geo.annotator --version 1.2.0

[phase1geo]

Is there a gnome icon package available for install? I believe those icons come standard in gnome environments.

[ernstki]

Since this issue happens to double as a handy guide to almost-building on Debian, I'll add these two requirements to the list above: libportal-gtk4 and libportal-gtk4.

So:

sudo apt install meson valac debhelper golang-gir-gobject-2.0-dev \
         golang-gir-glib-2.0-dev libgee-0.8-dev libgranite-dev libxml2-dev \
         libgtk-3-dev libhandy-1-dev libportal-gtk4 and libportal-gtk4

[ernstki]

Is there a gnome icon package available for install? I believe those icons come standard in gnome environments.

Edit: Turns out only elementary-icon-theme (used for the Pencil tool) creates a symlink for edit-symbolic.svg, and image-crop-symbolic.svg doesn't exist as a part of any other icon theme.

$ locate edit-symbolic.svg | grep ^/usr/share
/usr/share/gthumb/icons/hicolor/16x16/actions/edit-symbolic.svg
/usr/share/icons/Adwaita/scalable/actions/document-edit-symbolic.svg
/usr/share/icons/Obsidian/actions/scalable/document-edit-symbolic.svg
/usr/share/icons/elementary/actions/symbolic/document-edit-symbolic.svg
/usr/share/icons/elementary/actions/symbolic/edit-symbolic.svg

$ locate image-crop-symbolic.svg | grep ^/usr/share
/usr/share/gthumb/icons/hicolor/16x16/actions/image-crop-symbolic.svg
/usr/share/icons/elementary/actions/symbolic/image-crop-symbolic.svg

$ dpkg -S /usr/share/icons/elementary/actions/symbolic/image-crop-symbolic.svg
elementary-icon-theme: /usr/share/icons/elementary/actions/symbolic/image-crop-symbolic.svg

A PR is forthcoming.

[ernstki]

93 should address this, but the styling for the buttons is inconsistent, when viewed in the default GNOME theme. Some have 3-D bevels, some don't.

I've noticed this with other applications besides Annotator, and I suspect it's more to do with the rate-of-change of GTK's APIs than the developers' fault. I don't know what the GNOME HIGs say about it, but there doesn't seem (to me, the user) to be a clear reason other than aesthetics for buttons-with-bevels vs. the flat style.

I personally prefer the bevel, because 1) I grew up on Win 95 and OS/2; and 2) with bevels there's no anxiety about whether something is clickable/tappable, because the click targets are all an obvious, uniform size and shape.

But I can dig into it, if you like. Probably one is one kind of object, the other is another, or there's a flag to control the button border style that isn't applied consistently.

[phase1geo]

I've been working on a GTK4 port of Annotator which should have all of these UI issues fixed (minus your icon fixes).

[ernstki]

@phase1geo Thanks for your efforts!