phase2 / generator-pattern-lab-starter

This is a Yeoman Generator for pattern-lab-starter: https://github.com/phase2/pattern-lab-starter
10 stars 5 forks source link

Restore/fix implementation of theme name prompt #17

Closed altrugon closed 7 years ago

altrugon commented 7 years ago

I have noticed that the theme name and theme description values are not being used at all on the script. Below is the output from my console:

~/Desktop/tmp/patstat$ yo pattern-lab-starter

     _-----_
    |       |    .--------------------------.
    |--(o)--|    |      Welcome to the      |
   `---------´   |        remarkable        |
    ( _´U`_ )    |     PatternLabStarter    |
    /___A___\    |     generator! 2.0.0     |
     |  ~  |     '--------------------------'|                          |
   __'.___.'__   |  Please be in the folder |
 ´   `  |° ´ Y ` |  you want files in now.  |
                 '--------------------------'

? What would you like to name the theme? patstat
? What distribution of Drupal is installed? drupal
? What version of Drupal is installed? 8.x
? Description of project? "My awesome description."
? Want to install dependencies afterwards? No
     info ... Fetching https://github.com/phase2/pattern-lab-starter/archive/master.tar.gz ...
     info This might take a few moments
...
✔ Done in /Users/altrugon/.cache/yeoman/phase2/pattern-lab-starter/master
   create bower.json
   create package.json
...
   create yarn.lock

     _-----_
    |       |    .--------------------------.
    |--(o)--|    |         All done!        |
   `---------´   '--------------------------'|                          |
    ( _´U`_ )    |   Install dependencies   |
    /___A___\    |   with "npm install"Run  |
     |  ~  |     |   "npm start" to start.  |
   __'.___.'__   '--------------------------'|                          |
 ´   `  |° ´ Y ` |  See readme.md for more. |
                 '--------------------------'|                          |
                 |     Have a great day!    |
                 '--------------------------'

If you don't see your prompt, try hitting enter.
~/Desktop/tmp/patstat$ grep -r patstat ./
~/Desktop/tmp/patstat$ cat patternlab.info
name = Pattern Lab Starter
core = 7.x

; inject:css
stylesheets[all][] = dest/style.css
; endinject

; inject:js
scripts[] = dest/script.js
; endinject
~/Desktop/tmp/patstat$ ls -l
total 664
-rw-r--r--   1 altrugon  staff   10787 16 Jan 12:38 README.md
-rw-r--r--   1 altrugon  staff    1215 16 Jan 12:38 bower.json
-rw-r--r--   1 altrugon  staff     431 16 Jan 12:38 contributing.md
drwxr-xr-x   3 altrugon  staff     102 16 Jan 12:38 docs
-rw-r--r--   1 altrugon  staff    4740 16 Jan 12:38 favicon.ico
drwxr-xr-x   5 altrugon  staff     170 16 Jan 12:38 fonts
-rw-r--r--   1 altrugon  staff    5464 16 Jan 12:38 gulpconfig.js
-rw-r--r--   1 altrugon  staff     803 16 Jan 12:38 gulpfile.js
drwxr-xr-x  12 altrugon  staff     408 16 Jan 12:38 images
-rw-r--r--   1 altrugon  staff     135 16 Jan 12:38 index.html
drwxr-xr-x   4 altrugon  staff     136 16 Jan 12:38 js
-rw-r--r--   1 altrugon  staff     931 16 Jan 12:38 logo.svg
-rw-r--r--   1 altrugon  staff    1098 16 Jan 12:38 package.json
drwxr-xr-x   7 altrugon  staff     238 16 Jan 12:38 pattern-lab
-rw-r--r--   1 altrugon  staff       0 16 Jan 12:38 patternlab.breakpoints.yml
-rw-r--r--   1 altrugon  staff     152 16 Jan 12:38 patternlab.info
-rw-r--r--   1 altrugon  staff    1499 16 Jan 12:38 patternlab.info.yml
-rw-r--r--   1 altrugon  staff     222 16 Jan 12:38 patternlab.libraries.yml
-rw-r--r--   1 altrugon  staff      82 16 Jan 12:38 patternlab.theme
-rw-r--r--   1 altrugon  staff    4740 16 Jan 12:38 screenshot.png
drwxr-xr-x   3 altrugon  staff     102 16 Jan 12:38 scripts
drwxr-xr-x   4 altrugon  staff     136 16 Jan 12:38 scss
drwxr-xr-x  12 altrugon  staff     408 16 Jan 12:38 source
drwxr-xr-x   4 altrugon  staff     136 16 Jan 12:38 templates
-rw-r--r--   1 altrugon  staff  259346 16 Jan 12:38 yarn.lock

I was expecting to see files like patternlab.theme named patstat.theme, since that was the name I chose for the theme, also as you can see the description hasn't been added either.

Please let me know what I'm doing wrong, and thank you so much for all the work you have put over here.

grayside commented 7 years ago

These prompts were vestigial (or perhaps aspirational) but we're hoping to bring this feature back in coming months.

altrugon commented 7 years ago

Thank you so much for the reply.