phase2 / outline

Tooling infrastructure for modern web component development.
https://outline.phase2tech.com
MIT License
128 stars 27 forks source link

A11y fix: use aria-hidden for styling #297

Closed shaal closed 2 years ago

shaal commented 2 years ago

Description

Accessibility best practice says to change the style of an element base on aria when possible. Accordion was using an attribute hidden, this PR remove that attribute and update CSS to depend on aria-hidden instead. (The end result is the same)

How Has This Been Tested?

I tested the Accordion component in storybook, and confirmed accordion panels are shown/hidden.

Checklist: