phase2 / outline

Tooling infrastructure for modern web component development.
https://outline.phase2tech.com
MIT License
128 stars 27 forks source link

[Bug]: Can't override templates in components that inherit from OutlineModal #333

Closed mabry1985 closed 2 years ago

mabry1985 commented 2 years ago

I think this is an issue in a couple other components, but we need to use the protected and not private for the modifier if we want to be able to extend these methods from the base class.

https://github.com/phase2/outline/blob/next/src/components/base/outline-modal/outline-modal.ts