phase2 / outline

Tooling infrastructure for modern web component development.
https://outline.phase2tech.com
MIT License
128 stars 27 forks source link

fix: aria-hidden shouldn't be treated as visually hidden #360

Closed shaal closed 1 year ago

shaal commented 1 year ago

Description

Although it's often a good idea to target aria-hidden in CSS, and make it also visually hidden, there are specific cases where aria-hidden is important for hiding things from screen-reader but WITHOUT visually hide the element. (This fix should also fix the Splide flickering issue when changing slides)

Fixes # (issue)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 5892abc80eed51993f93bff7f4be14c98ad7bec1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR