phase2 / outline

Tooling infrastructure for modern web component development.
https://outline.phase2tech.com
MIT License
128 stars 27 forks source link

Refactor css variables for all components to reflect ADR. #368

Closed mike-potter closed 1 year ago

mike-potter commented 1 year ago

Description

Refactors all usage of CSS Variables to comply with https://github.com/phase2/phase2-adr/pull/17

Components affected:

In addition to supporting the naming convention listed in the ADR, especially around the use of --computed, also modified the styles.js script to avoid adding :host{} around files in the css-variables folder in favor of putting the :host directly in the vars.css files themselves. This change:

Type of change

Please delete options that are not relevant.

This is a breaking change for any project currently using the new mono repo and overriding CSS variables since some variables have changed names.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 5540394d698c008ce9c77d0b6a8f660e27e44534

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR