phase2 / outline

Tooling infrastructure for modern web component development.
https://outline.phase2tech.com
MIT License
128 stars 27 forks source link

WIP feat/outline-nav-menu #376

Open LeeMellon opened 1 year ago

LeeMellon commented 1 year ago

Description

Still WIP but in a reviewable state

Adds: outline-nav component and sub-components.

Notes:

Can work with:

  1. Pre-formatted data see default export
  2. JSON:API Menu Items Drupal Module see example of data model here at jsonData
  3. Can be slots all the way down. see SlotsTemplate in storybook

To test with JSON API:

  1. Spin up a Drupal demo environment and install the JSON:API Menu Item module

  2. Build your menu in admin/structure/menu/manage/main

    Cursor_and_Edit_menu_Main_navigation___Phase2_Drupal_Demo
  3. Spin up an Outline repo and launch storybook.

  4. Verify the JSON API endpoint is working at [docksal evntronment]/jsonapi/menu_items/main (if you're test menu is the main navigation)

5 Use chrome Cross Domain CORS extension to allow fetch test

  1. Paste the endpoint URL into the menuEndpoint in the story and refresh.
Cursor_and_Screen_Shot_2023-04-07_at_14_51_09_PM_png Cursor_and_Navigation___Outline_Main_Menu_-_Nav_With_Dynamic_Fetch_URL_⋅_Storybook

Still needs:

  1. Styling
  2. QOL updates
  3. Full accessibility testing. Fixes # (issue)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 1b53af3af6d614b40813207d8520c0b2810271d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for outlinejs ready!

Name Link
Latest commit 1b53af3af6d614b40813207d8520c0b2810271d8
Latest deploy log https://app.netlify.com/sites/outlinejs/deploys/646bafd7dbe30900089601de
Deploy Preview https://deploy-preview-376--outlinejs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

socket-security[bot] commented 1 year ago

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
lodash-es@4.17.21 eval +0 bnjmnt4n
@types/lodash-es@4.17.7 None +0 types
@types/lodash@4.14.194 None +0 types