Closed tekante closed 1 year ago
Latest commit: c05263d0f5d111226303301e2f860306a403c941
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Name | Link |
---|---|
Latest commit | c05263d0f5d111226303301e2f860306a403c941 |
Latest deploy log | https://app.netlify.com/sites/outlinejs/deploys/644dc8feb1921200080dcaa8 |
Deploy Preview | https://deploy-preview-382--outlinejs.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Commit c05263d0f5d111226303301e2f860306a403c941 fixes the error on yarn run start
but it looks like it does not actually fix it for yarn run build
so changing title of this to WIP since I don't see a way to convert this back to a draft PR
Based on https://github.com/phase2/outline/pull/385/files the changes in https://github.com/phase2/outline/pull/385/commits/f0c5d516f25f12fc278d03bfa5c49cf1835cd1a1 and https://github.com/phase2/outline/pull/385/commits/8a049d2ce1575a4d7f96d04a71ec83d546361e23 are needed as well. Going to close this one in favor of #385
Description
Change the import reference to light-dom to avoid the following error on
yarn run start
:Fixes #378
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist