phase2 / outline

Tooling infrastructure for modern web component development.
https://outline.phase2tech.com
MIT License
128 stars 27 forks source link

fix: remove lightDomStyles import from core #402

Closed bardleb closed 1 year ago

bardleb commented 1 year ago

Description

Removing the import for lightDomStyles controller as it currently prevents any components from being created by developers.

Issues blocking projects documented here: https://phase2.slack.com/archives/C01RRSPB62F/p1687539660099819

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: cb34fd638fff54e92742a4ec2ce8aa62e3919d50

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for outlinejs ready!

Name Link
Latest commit cb34fd638fff54e92742a4ec2ce8aa62e3919d50
Latest deploy log https://app.netlify.com/sites/outlinejs/deploys/649988f2051ccf0008fb56fe
Deploy Preview https://deploy-preview-402--outlinejs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

mike-potter commented 1 year ago

So yes, the outline-form component uses the LightDomStyles, so you'd need to remove it also.

But this makes me wonder why the previous outline-form component WAS working and extending OutlineElement, but somehow projects can't create their own components from OutlineElement??

himerus commented 1 year ago

Closed in favor of work that fixed the primary issue, and upcoming work to address the future state of this particular functionality.