search

phase2 / outline

Tooling infrastructure for modern web component development.
https://outline.phase2tech.com
MIT License
128 stars 27 forks source link

OUTLINE-167: `outline-core-heading`: Heading Component #403

Open shaal opened 1 year ago

shaal commented 1 year ago

Description

<outline-core-heading>

Summary by CodeRabbit

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 2f08402c45d234056f847ce8536a17dad36fe3c3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for outlinejs failed.

Name Link
Latest commit 2f08402c45d234056f847ce8536a17dad36fe3c3
Latest deploy log https://app.netlify.com/sites/outlinejs/deploys/65c24416d01d9600088b9283
socket-security[bot] commented 1 year ago

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@phase2/outline-core@0.1.12 None +1 453 kB himerus

View full report↗︎

coderabbitai[bot] commented 10 months ago

Walkthrough

The overall change introduces a new outline-core-heading component with customizable properties for classes, heading levels, sizes, and weights. It includes updates to CSS for styling, tests for the new component, and storybook configurations. Additionally, there's an outline-extended-button that extends the core button functionality with a new variant. The changes are spread across component definitions, configurations, styles, and documentation updates.

Changes

File Path Change Summary
.../outline-core-heading/README.md Added documentation for outline-core-heading component.
.../outline-core-heading/index.ts Exported OutlineCoreHeading component and related types.
.../outline-core-heading/src/config.ts Updated HeadingSizes and HeadingWeights with specific values and types.
.../outline-core-heading/src/...core-heading.css Added CSS styling rules for text sizes and font weights.
.../outline-core-heading/src/...core-heading.lightdom.css Added CSS classes for text sizes, font weights, and clickable card.
.../outline-core-heading/src/outline-core-heading.ts Introduced OutlineCoreHeading component with properties and methods.
.../outline-core-heading/src/test/...core-heading.test.ts Added test suite for outline-core-heading component.
.../outline-storybook/config/storybook.main.css Reformatted and added new CSS variables.
.../outline-storybook/stories/...heading.stories.ts Updated imports and properties for outline-core-heading stories.
.../outline-templates/default/src/.../outline-extended-button/index.ts Exported OutlineExtendedButton.
.../outline-templates/default/src/.../outline-extended-button/outline-extended-button.css Added new CSS rule for class "shiny".
.../outline-templates/default/src/.../outline-extended-button/outline-extended-button.ts Modified imports, updated button variants, and declared OutlineExtendedButton class.
Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository from git and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
glitchgirl commented 8 months ago

TODO: @shaal -review and update CSS to be nicer :)