Closed shaal closed 8 months ago
Latest commit: 2a7f3425c0262adbd53bef6ef8e4ea3933699786
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Name | Link |
---|---|
Latest commit | 2a7f3425c0262adbd53bef6ef8e4ea3933699786 |
Latest deploy log | https://app.netlify.com/sites/outlinejs/deploys/65c264982a5ace0008a4845c |
Deploy Preview | https://deploy-preview-420--outlinejs.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
[!IMPORTANT]
Auto Review Skipped
Draft detected.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository.To trigger a single review, invoke the
@coderabbitai review
command.
Closing in favor of the slim @phase2/outline-adopted-stylesheets-controller controller
Description
This PR simplifies how we add slot styles from within the component.
Style Manager controller does the following:
Reads the CSS (that alternatively could be loaded globally by the consumer)
Only if
generateRandomId === true
-:host
and:root
Uses
adoptedStylesheets
to modify the document's CSS (instead adding CSS into the DOM)