search

phase2 / p2-theme-core

Core configuration for Pattern Lab Starter/Particle v9
16 stars 22 forks source link

Allow iconfont timestamp to be configured #10

Closed jeffm2001 closed 8 years ago

jeffm2001 commented 8 years ago

This is a minor thing, but was driving me crazy. The generated icon fonts have a timestamp embedded, which means that the files show up as changed on every build/deploy.

This PR allows me to set the timestamp to 0 in my config so that the files stay the same unless I actually make changes.

See: https://github.com/nfroidure/gulp-iconfont/issues/70

EvanLovely commented 8 years ago

Thanks for pointing this out! I'm choosing to implement this a little different as Yaml will parse the default config as 'runTimestamp' (a string), instead of the runTimestamp variable set from var runTimestamp = Math.round(Date.now() / 1000); I've added a new config option under icons of useTimestamp that you can set to true or false. The default is false and then passes in a 0, where true preserves previous behavior. This is released in v8.1.1 just now. Thanks!