phase2 / rig

Outrigger command line tool
MIT License
11 stars 8 forks source link

Add gometalinter #102

Closed febbraro closed 7 years ago

febbraro commented 7 years ago

added linting and addressed all feedback (and ignored 3)

Addresses #92

grayside commented 7 years ago

Did I miss travis config?

febbraro commented 7 years ago

I didn;t add travis configuration yet. I was not sure if we wanted to fail the build on linter warnings. Maybe we should? I had to exempt 3 functions from linting, one due to some nested error conditions that was not ready mentally to unpack and 2 for cyclomatic complexity. They should all be reworked but I wanted to get the superficial warnings covered and then take an separate PR to attack the complexity issues in Doctor and ProjectConfig validation.

febbraro commented 7 years ago

Added travis integration for the linter