phase2 / rig

Outrigger command line tool
MIT License
11 stars 8 forks source link

Add spinner support to rig project sync[:stop] #141

Closed grayside closed 6 years ago

grayside commented 6 years ago

This is a first take, I think there's some language and formatting tightening potential, but it all seems to work as you'd expect.

tekante commented 6 years ago

I dropped a few notes about where I don't see messages though I consider that not particularly blocking.

Here is the sequence I see: Spinner: Starting Outrigger Filesync (unison) Checkmark: Starting sync volume: nwpl-sync (overwrites prev spinner) Spinner: Starting sync container: nwpl-sync (same name) Checkmark: Sync container 'nwpl-sync' started (overwrites prev spinner) Spinner: Initializing file sync... Checkmark: Initial sync detected (overwrites prev spinner) Spinner: Waiting for initial sync to finish Checkmark: File sync completed (overwrites prev spinner)

tekante commented 6 years ago

One other thing I noticed (which I also don't think needs to block) is the error message doesn't work as nicely as the success messages do. Since the message is getting returned however it doesn't seem to be as simple as swapping it to a logger message. Perhaps doing a log message and then returning the error?

rig-project-sync-error

tekante commented 6 years ago

Adjusted error message to work better with spinner

rig-project-sync-error-split