phasehq / kubernetes-secrets-operator

Securely sync secrets and environment variables with Phase in your Kubernetes cluster
GNU General Public License v3.0
5 stars 1 forks source link

hotfix: fix error when trying to skip ssl verify using envar PHASE_VE… #14

Closed dodistyo closed 1 month ago

dodistyo commented 1 month ago

It looks like it missing parameter verify in the request code. It will throw an error: requests.exceptions.SSLError: HTTPSConnectionPool(host='<cencored>', port=443): Max retries exceeded with url: /service/secrets/tokens/ (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self-signed certificate (_ssl.c:1006)')))

nimish-ks commented 1 month ago

@dodistyo cheers.

Keep in mind you will have to pass the PHASE_VERIFY_SSL=False flag as an env to the pod. The simplest way would be to use helm.

dodistyo commented 1 month ago

Got it, Thanks. I could add it to the helm chart value when I got time. do you want me to make a PR later? @nimish-ks

nimish-ks commented 1 month ago

@dodistyo sure, feel free!