search

phaselden / FlipIt

Flip Clock screensaver
Creative Commons Zero v1.0 Universal
1.08k stars 126 forks source link

Feature request: Close on mouse move #12

Closed SmilerRyan closed 3 years ago

SmilerRyan commented 3 years ago

Unlike the old/standard Fliqlo project, this is a great project. I would like the option to have it close on mouse movement, as well as just by click or keypress. Preferably, I would think this option should be enabled by default as most screensavers close on movement.

redburn commented 3 years ago

It does for me. Exit on mouse movement, that is.

explor202 commented 3 years ago

My mouse has a built in sleep feature, so depending on how long it's been inactive may require a click one of it's buttons to wake it up first. But either way mouse movement closes the screensaver for me too.

SmilerRyan commented 3 years ago

I have the screensaver automatically start after 3 minutes, and my mouse does not go to sleep. After re-checking, it only seems to close if I continue to move the mouse for over a second. Is this an intended feature?

explor202 commented 3 years ago

Sounds like an issue with your mouse or some setting with it. If my mouse isn't asleep, the screensaver closes with the slightest bit of movement of it.

SmilerRyan commented 3 years ago

I believe I have average mouse settings, it only seems to close quickly if I move it agressively. I have attached my mouse speed settings below, along with the example speed. Edit: I've also tried on a public virtual machine and it appears that it has the same issue.

SmilerRyan commented 3 years ago

After checking the movement event, I have discovered that it does check if it has moved such a distance. Removing the check closed the program as soon as it started (the mouse moved 0 pixels). Lowering it from 5 to a lower number (like 2) did not help, but 0 did fixed my problem.

I will make a pull request with the change now, and I hope this helps others who experience the same issue as me. image