Fix for webGL performance on mobile devices and other issues

phaserjs / phaser-ce

Phaser CE is a fun, free and fast 2D game framework for making HTML5 games for desktop and mobile web browsers, supporting Canvas and WebGL rendering.

http://phaser.io

MIT License

1.34k stars 491 forks source link

Fix for webGL performance on mobile devices and other issues #641

Closed jamieallen1234 closed 5 years ago

jamieallen1234 commented 5 years ago

This PR is a is a bug fix (closes #356)

Describe the changes below:

Fix for webGL making excessive gl calls, which was negatively impacting the frame-rate of low-end machines and mobile devices. (broken since original fork of phaser 2)
Fix for smoothed setting on textures not being respected.
Fix for updateTexture happening on textures that hadn't loaded their source yet.
Fix for flickering issue on some android devices.
Fix eslint errors.

samme commented 5 years ago

Thanks for this.

Fix for AUTO render setting not properly falling back to canvas if not compatible with webGL.

Can you demonstrate this issue? I thought I'd tested this case. I'll take another look, in any case.

jamieallen1234 commented 5 years ago

Thanks for this.

Fix for AUTO render setting not properly falling back to canvas if not compatible with webGL.

Can you demonstrate this issue? I thought I'd tested this case. I'll take another look, in any case.

Your right, the fix wasn't needed. We were having issues on this 6 months ago on an older version of phaser-ce, but it seems fine now so I reverted my changes.

Weedshaker commented 4 years ago

@jamieallen1234 , thank you for the performance improvements but do may know why texture atlases are being mangled up since 2.13.3? See here: https://github.com/photonstorm/phaser-ce/issues/644 and I had even worse effects on other devices, where whole buttons etc. were missing. I assume it has something to do with image batching and picture atlas and is to 100% related with this #641 . THX for looking into it.

Weedshaker commented 4 years ago

@jamieallen1234 , your change removed multi-texture support. Could you please participate at: https://github.com/photonstorm/phaser-ce/issues/644#issuecomment-577242165 and help fixing the mess #641 caused!? THX