search

phaserjs / phaser-ce

Phaser CE is a fun, free and fast 2D game framework for making HTML5 games for desktop and mobile web browsers, supporting Canvas and WebGL rendering.
http://phaser.io
MIT License
1.35k stars 490 forks source link

fix fileComplete reference error in Loader.loadVideoTag #743

Closed Akurn closed 1 month ago

Akurn commented 1 month ago

This PR is a bug fix (closes #742)

Please include a summary in Change Log: Unreleased and thank yourself.

Describe the changes below: The game.load reference in the videoLoadEvent callback gets nulled when the game is destroyed. This uses the local reference for fileComplete instead.

Akurn commented 1 month ago

Just checking if this the correct way to make a PR? Also do I need to add to the CHANGELOG? Thanks @samme 🙏

samme commented 1 month ago

I can do the CHANGELOG.