JSDoc and type for parent property

phaserjs / phaser

Phaser is a fun, free and fast 2D game framework for making HTML5 games for desktop and mobile web browsers, supporting Canvas and WebGL rendering.

https://phaser.io

MIT License

37.16k stars 7.1k forks source link

JSDoc and type for parent property #6815

Closed lgtome closed 5 months ago

lgtome commented 6 months ago

Please do not update the README or Change Log, we will do this when we merge your PR.

This PR

Updates JSDoc
Fixes a bug

Describe the changes below:

I was using typescript and I found a mismatching property with JSDoc and typescript. Here is the screenshot with JSDoc and an error from typescript. I added null type for JSDoc.

Thank you!

photonstorm commented 6 months ago

Thanks for the PR - could you please remove the types def from it, we only need the JSDoc change itself.

photonstorm commented 5 months ago

👍