Add missing type defs to TweenChainBuilderConfig

phaserjs / phaser

Phaser is a fun, free and fast 2D game framework for making HTML5 games for desktop and mobile web browsers, supporting Canvas and WebGL rendering.

https://phaser.io

MIT License

37.16k stars 7.1k forks source link

Add missing type defs to TweenChainBuilderConfig #6894

Closed ospira closed 2 months ago

ospira commented 3 months ago

This PR

Fixes a bug

Describe the changes below:

Similar to this, updated Phaser.Types.Tweens.TweenChainBuilderConfig typedef to match this documentation (note the presence of onUpdate and onUpdateParams)

Note similarity with related class/def in both typedef and documentation

samme commented 2 months ago

TweenChainBuilderConfig @ v3.80.0 is actually incorrect because tween chains don't use onUpdate or onUpdateParams. The docs for v3.80.1 are correct.

https://github.com/phaserjs/phaser/pull/6741

ospira commented 2 months ago

thanks, understood. closing.