phatboyg / Machete

Cut through the Crap, with Machete, a text parser, object mapper, and query engine.
Apache License 2.0
53 stars 26 forks source link

Handling of "Not Used" Elements #55

Closed nycbauer closed 6 years ago

nycbauer commented 6 years ago

I'm trying to parse an X12 835 document, and the NM1 Segment has space for "Name Prefix" - NM106, which is labeled as "Not Used" in the documentation, however, I see that in your code you are ignoring this field.

For reference sake, I am getting my information from here: https://reviewer.x12.org/x322publicreviewweb Then navigating to 2.4 \ Table 2 - Detail \ Loop 2100 - Claim Payment Information \ NM1 - Patient Name. And I see in your code: Generated\V5010\Segments\Maps\NM1Map.cs - Line 20 sets position 6 to Name Suffix instead of Name Prefix.

Thank you!

ahives commented 6 years ago

Good catch. The fix is to increment the index for suffix to 7, qualifier to 8, and code to 9. Fix will be in need release.

ahives commented 6 years ago

fixed in release 1.0.236-develop

ahives commented 6 years ago

@nycbauer is this still an issue?

nycbauer commented 6 years ago

Nope, thank you!