phatworx / devise_security_extension

An enterprise security extension for devise, trying to meet industrial standard security demands for web applications.
MIT License
747 stars 346 forks source link

New release compatible with devise 4 #192

Open mrdomino opened 8 years ago

mrdomino commented 8 years ago

0.10.0 requires devise < 4, so it's impossible to use both the latest devise and the latest devise_security_extension. It'd be great to have a release from current master, which doesn't seem to have this problem.

borisrorsvort commented 8 years ago

@manno any update on this one?

manno commented 8 years ago

I'm not using devise_security_extension myself and I don't have access to the rubygems account (https://github.com/phatworx/devise_security_extension/issues/178). However I do still have commit access, so I could merge a PR to make master work with modern Rails.

Long-term, someone with rubygems access needs to step up or the actual users will have to fork the project. It would really benefit from some active maintainers. That would be a good opportunity to split this into smaller gems, too.

borisrorsvort commented 8 years ago

@manno tried this one and it seems to work fine https://github.com/phatworx/devise_security_extension/pull/195

manno commented 8 years ago

@borisrorsvort #195 is now merged

mvz commented 7 years ago

@manno what needs to happen for a new gem to be pushed to rubygems?

khataev commented 7 years ago

+1 for compability with devise 4.0

ericenns commented 7 years ago

Any update on this I need Devise 4.2 so I can deploy via sub path

v3rron commented 7 years ago

Same here, can't install this Gem due to dependency conflict with Devise 4.2. Please push the update to RubyGems.

Drenmi commented 7 years ago

Phatworx website is no longer available, so is it safe to assume that no-one is maintaining this anymore?

adamdullenty commented 7 years ago

+1 on not being able to install this due to dependency conflict with Devise 4.2.

natebird commented 7 years ago

I'm not trying to fork or take over the project but if you'd like to use my repo I've updated it for Rails 5 / Devise 4 compatibility.

https://github.com/natebird/devise_security_extension

I also changed the gem tag to 0.10.1 just so I could differentiate versions in my software.

dillonwelch commented 7 years ago

@natebird FYI I have https://github.com/phatworx/devise_security_extension/pull/216 up if you need Ruby 2.4 support, I can make a PR on your fork too.

natebird commented 7 years ago

That would be nice.

Thanks!

Nate

On Apr 5, 2017, at 1:28 PM, Dillon Welch notifications@github.com wrote:

@natebird https://github.com/natebird FYI I have #216 https://github.com/phatworx/devise_security_extension/pull/216 up if you need Ruby 2.4 support, I can make a PR on your fork too.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/phatworx/devise_security_extension/issues/192#issuecomment-291935761, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAR0HgeDwBEn0KTBjduJchssaZgna6Vks5rs886gaJpZM4JRRYG.

toobulkeh commented 7 years ago

@natebird would you be willing to fork this into a different Gem? even just differently named so we can use rubygems over some kind of git reference would definitely help

dillonwelch commented 7 years ago

The approach I'd like to see is getting these into the main devise gem

vinagrito commented 7 years ago

@traxanos

natebird commented 7 years ago

@toobulkeh, @oniofchaos - I would like to investigate the following solutions:

mvz commented 6 years ago

There's a forked gem devise-security: https://github.com/devise-security/devise-security