search

phatworx / devise_security_extension

An enterprise security extension for devise, trying to meet industrial standard security demands for web applications.
MIT License
747 stars 346 forks source link

Replace low-priority operators #214

Open HenryKeiter opened 7 years ago

HenryKeiter commented 7 years ago

The operator inconsistencies have always bugged me. High-priority (&&, ||, !) and low-priority (and, or, not) operators are used interchangably throughout the code, and it's caused bugs in the past. This is an attempt to standardize them to the high-priority operators so there's less chance of future mishaps.

I also found a couple of operators which were missing altogether, so I added those in.

tibbon commented 6 years ago

This looks great. Is there anything needed to merge this?