search

phatworx / devise_security_extension

An enterprise security extension for devise, trying to meet industrial standard security demands for web applications.
MIT License
747 stars 346 forks source link

Fix Ruby 2.4 deprecations #216

Open dillonwelch opened 7 years ago

dillonwelch commented 7 years ago

lib/devise_security_extension/models/password_archivable.rb:20: warning: constant ::Fixnum is deprecated

I'm upgrading my app to Ruby 2.4 and getting these deprecations everywhere.

rsullivan00 commented 7 years ago

This successfully removes the warnings for me on Ruby 2.4.1 👍

rsullivan00 commented 7 years ago

Is there anything stopping merging this branch? This warning is driving me crazy.

dillonwelch commented 7 years ago

Someone with merge permissions :trollface:

knightq commented 7 years ago

Please merge

wakproductions commented 7 years ago

Is this gem still actively maintained?

dillonwelch commented 7 years ago

Unfortunately it doesn't appear so. A couple of us have made a fork called devise-security

tibbon commented 6 years ago

Any reason to not merge this?

olbrich commented 6 years ago

@tibbon This repo is pretty much unmaintained at this point... try the fork of it at https://github.com/devise-security/devise-security