search

phausamann / sklearn-xarray

Metadata-aware machine learning.
http://bit.do/sklearn-xarray
BSD 3-Clause "New" or "Revised" License
102 stars 12 forks source link

Refactor 'reshapes' mechanism #56

Open phausamann opened 3 years ago

phausamann commented 3 years ago

The reshapes parameter is confusing and in reality only necessary if the number of dimensions changes.

Proposal:

  1. Check if number of dimensions has changed, if yes check for reshapes parameter and raise error if not specified.
  2. Otherwise check if size of axes/dimensions have changed and drop coords accordingly.