phavekes / unmangleOutlookSafelinks

Thunderbird plugin to unmangle Outlook Protection Safelinks
GNU General Public License v3.0
14 stars 10 forks source link

Does not work on Thunderbird 78 #18

Closed nwhitehorn closed 3 years ago

nwhitehorn commented 4 years ago

I think it needs the new "messageDisplayScripts" API (starting in Thunderbird 82) to work, so it's probably impossible to make it run in Thunderbird 7x and the shell parts will need to be rewritten for Thunderbird 8x+.

nwhitehorn commented 3 years ago

Similar addon for Thunderbird 78.4+:

https://addons.thunderbird.net/en-US/thunderbird/addon/safelink-removal/

cschaffner commented 3 years ago

Similar addon for Thunderbird 78.4+:

https://addons.thunderbird.net/en-US/thunderbird/addon/safelink-removal/

I'm not sure this other add-on is doing the same, I can't get it to work...

nwhitehorn commented 3 years ago

I think it needs an update (I built from source), but it does work and is functioning for me as a full replacement.

phavekes commented 3 years ago

I'll put the update om my list... Please be patient ...

phavekes commented 3 years ago

Converting deprecated Legacy WebExtensions to MailExtensions is not simple :disappointed:

phavekes commented 3 years ago

It seems the necessary API's are not working until version 82+ https://thunderbird-webextensions.readthedocs.io/en/78/changes/beta82.html

nwhitehorn commented 3 years ago

They've been back-ported to 78.4 and onward.

phavekes commented 3 years ago

I've got a working version for TB82, I'll release a xpi for testing on github today.

phavekes commented 3 years ago

19

phavekes commented 3 years ago

This xpi can be used for testing: https://github.com/phavekes/unmangleOutlookSafelinks/raw/feature/TB78/unmangleOutlookSafelinks-3.0.0.xpi

phavekes commented 3 years ago

They've been back-ported to 78.4 and onward.

I don't see messageDisplayScripts before version 82 : https://thunderbird-webextensions.readthedocs.io/en/78/changes/beta82.html#messagedisplayscripts-tabs

Where have you seen the backporting of this API?

nwhitehorn commented 3 years ago

Here: https://thunderbird-webextensions.readthedocs.io/en/78/messageDisplayScripts.html

phavekes commented 3 years ago

The update for version 78 (almost 90% rewrite) is published in the addon store now: Get it here Please submit any problems in a new issue here.