search

phax / as2-lib

A generic Java AS2 library, servlet and server
107 stars 43 forks source link

It should be easier to override the catch-all behavior in AS2SenderModule #11

Closed jochenberger closed 8 years ago

jochenberger commented 8 years ago

If an exception occurs while receiving an MDN, the error is just logged but not thrown out of the module. The calling code has no way to know that there was an error. I suggest extracting the relevant code (AS2SenderModule, lines 659-664) into a protected method. or calling an overridable no-op method from the catch block.

phax commented 8 years ago 
@OverrideOnDemand
  protected void onReceivedMDNError (@Nonnull final AS2Message aMsg, @Nonnull final OpenAS2Exception ex)