search

phax / jcodemodel

A heavily extended fork of the com.sun.codemodel (from 2013/09)
Other
93 stars 34 forks source link

Local 82 #92

Closed phax closed 3 years ago

phax commented 3 years ago

The branch for #82

guiguilechat commented 3 years ago

is it working ? Did not test. No issue with licensing ?

phax commented 3 years ago

It works for me. I don't see an issue with licensing, as it only uses runtime stuff. Or do you have anything particular in mind?

guiguilechat commented 3 years ago

Nothing in mind, just asking in case you had.

guiguilechat commented 3 years ago

"it works" as "the tests I designed a year ago have passed" or "your own test have passed" ?

phax commented 3 years ago

I assume you agree that the code you provided can be re-published under the projects license :)

guiguilechat commented 3 years ago

Of course, I just took several parts of code and it's up to you to do what you want with it.

phax commented 3 years ago

I added some tests and in general it looks good. Errors are detected as errors, and valid ones just do what they are supposed to do. The future extensions are pretty clear - write to disk optional etc.