search

phax / maven-jaxb2-plugin

The most advanced JAXB 2.x/3.0/4.0 Maven Plugin for XML Schema compilation.
BSD 2-Clause "Simplified" License
7 stars 2 forks source link

Add support for JAXB 3.0.0 #4

Closed adamretter closed 3 years ago

adamretter commented 3 years ago

This is a first draft at implementing support for JAXB 3.

I would appreciate any feedback on the code or testing...

I should likely add more Integration Tests yet!

phax commented 3 years ago

Okay, will check if I have time

dizzzz commented 3 years ago

Nice initiative! In the end this 'jaxb3' stuff is needed. So the "com.sun.tools.xjc" packages are not renamed?

phax commented 3 years ago

So you suggest I merge it? Haven't had the time yet... @dizzzz

adamretter commented 3 years ago

@phax I would be happy to wait for your review before merging.

adamretter commented 3 years ago

@phax thanks for your review. I pushed some updates. Do you want to merge this before I fork it, or should I fork it first?

phax commented 3 years ago

I would merge and change the version. Do you want me to build a release as well, or are you able to push to Maven Central as well?

adamretter commented 3 years ago

I can push under our groupId. If you would like a release under your groupId I can't do that though

phax commented 3 years ago

Great if you can do it. To avoid redundancies I guess it would be smarter to have only one Jaxb 3 release

phax commented 3 years ago

If you are chaning the group ID anyway, you can change the version as well. So I am merging this anbd you are taking it from there. Thanks for your effort!

soc commented 1 year ago

I apologize for intruding – the README says

We are happy for users to open issues, however we make no claims that we will investigate or resolve them.

but GitHub Issues are disabled in this repository.

I'm trying to use the 3.0 functionality and I'm seeing

A required class was missing while executing com.evolvedbinary.maven.jvnet:jaxb30-maven-plugin:0.15.0:generate: javax/xml/bind/JAXBException

Is this a known issue, or does it make sense for me to investigate and try to fix it? If I figure out the issue, would a PR be accepted?

Sorry again if you did not intend to receive issues/question.

Thanks,

Simon

phax commented 1 year ago

Well, the situation is a bit tricky. I was happy as EvolvedBinary was able to publish the 0.15 version with JAXB 3 support under their name. Unfortunately they struggeled with the update PR to JAXB 4 so I published again under my coordinates as 0.16.1 version - but I hadn't yet had the time to update the README accordingly.

So if you use com.helger.maven:jaxb30-maven-plugin:0.16.1 you get the latest version of JAXB 3.

A PR definitively gets accepted if it effects the latest version :)

phax commented 1 year ago

And Issues are enabled again - I disabled then when moving to EvolvedBinary - thanks for the reminder

soc commented 1 year ago

@phax Thank you, I will try to reproduce it tomorrow and report back!

In general, should I expect that changing the namespace of the binding element from sun/java to jakarta and updating its version attribute to 3.0 is required to run the tool successfully?

phax commented 1 year ago

I would assume so. But there is also a namespace change from http://java.sun.com/xml/ns/jaxb to https://jakarta.ee/xml/ns/jaxb