Running the prepareToMigrate against the real SMK results in ERR-106 about the 'quality' of the migration key

kukel commented 4 years ago

Version: 8.1.2-SNAPSHOT

The error I receive when doing:

 aPIClientDescartes.prepareToMigrate(aPI, SMP_ID);

[ERR-106] The migration code [ 77a9f1b1-0438-43f3-b56c- ] must contain a minimum of (8 characters,2 Upper Case letters,2 Lower Case letters,2 Special Characters among @#$%()[]{}*^-!~|+= and 2 numbers), a maximum of 24 characters and No White Spaces.

I'll see if I cant create a PR so it peppol-commons conforms with this. Weird...

Off-topic: In the method signature for the prepareToMigrate and migrate the parameters are reversed compared to the other methods. Intentional?

kukel commented 4 years ago

Sorry, no PC at hand to create a PR, so a working piece of code is here: Might need some optimization coding rules wise

  private static final String _upper = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";

  private static final String _lower = _upper.toLowerCase(Locale.ROOT);

  private static final String _digits = "0123456789";

  private static final String _symbols = "@#$%()[]{}*^-!~|+=";

  /**
   * @return A new random migration key with at last 24 characters and in line with SML requirements
   *  must contain 
   *  a minimum of 8 characters
   *   - 2 Upper Case letters
   *   - 2 Lower Case letters
   *   - 2 Special Characters among @#$%()[]{}*^-!~|+=
   *   - 2 numbers)
   *  a maximum of 24 characters
   *  No White Spaces.
   */
  @Nonnull
  @Nonempty
  public static final String createRandomMigrationKey ()
  {

    Random rand = new SecureRandom();
    String upper = nextString(2, rand, _upper);
    String lower = nextString(2, rand, _lower);
    String number = nextString(2, rand, _digits);
    String symbols = nextString(2, rand, _symbols);
    String other = nextString(16, rand, _upper+_lower+_digits+_symbols); //Add 16 randomly from the complete set to get to 24

    String sKey = (upper+lower+number+symbols+other);

    List<Character> key = sKey.chars().mapToObj(c -> (char) c).collect(Collectors.toList()); // String to List<Character> for shuffle
    Collections.shuffle(key, rand); // Shuffle so all characters are in a random order 
    sKey = key.stream().map(String::valueOf).collect(Collectors.joining()); // List<Character> to String

    return getSuitableMigrationKey (sKey);
  }

  /** Creates String of length 'length' from the set of 'charSet' and uses the provided 'random' 
   * 
   * @param length
   * @param random
   * @param charSet
   * @return
   */
  private static String nextString(int length, Random random, String charSet) {
    final char[] buf = new char[length];
    char[] chars = charSet.toCharArray();
    for (int idx = 0; idx < buf.length; ++idx)
      buf[idx] = chars[random.nextInt(chars.length)];
    return new String(buf);
  }