search

phax / ph-asic

Generic implementation of ASiC-E archives in accordance with ETSI 102 918 v1.3.1.
Mozilla Public License 2.0
1 stars 3 forks source link

asicmanifest.xml sould be called ASiCManifest.xml #3

Closed stefan2904 closed 4 years ago

stefan2904 commented 4 years ago

In multiple locations, ph-asic creates the ASiC manifest file named META-INF/asicmanifest.xml, while many libraries expect it to be called META-INF/ASiCManifest.xml.

Is there a reason this is done that way, or is this a bug?

./com/helger/asic/CadesAsicWriter.java:    m_aAsicOutputStream.writeZipEntry ("META-INF/asicmanifest.xml", aManifestBytes);
./com/helger/asic/AsicUtils.java:  public static final Pattern PATTERN_CADES_MANIFEST = Pattern.compile ("META-INF/asicmanifest(.*)\\.xml",
./com/helger/asic/AsicUtils.java:                aAOS.putNextEntry (new ZipEntry ("META-INF/asicmanifest" + nManifestCounter + ".xml"));

According to ETSI TS 102 918 V1.3.1:

Selection_999(478)

DSS also assumes that the file is called ASiCManifest.xml and cannot load a container created using ph-asic (The manifest file is absent! etc.).

This is also a issue in the repo from which you forked: https://github.com/difi/asic/issues/7

phax commented 4 years ago

Thanks for the comment. Highly appreciated. Will be fixed ASAP.

phax commented 4 years ago

Fixed in v1.4.1

stefan2904 commented 4 years ago

Hey Philip, thanks a lot for the fast fix! Cheers from Graz.

phax commented 4 years ago

Hey Stefan - yw. If you find more issues, just let me know. I know others (Greece) are also digging into the DSS inconsistencies atm. Xades stuff will btw. be deprecated and most likely removed...

phax commented 4 years ago

Btw. do you need a new release or is it just "for my information"?

stefan2904 commented 4 years ago

I know others (Greece) are also digging into the DSS inconsistencies atm.

University of Piraeus? ;-)

Btw. do you need a new release or is it just "for my information"?

We don't use ph-asic directly, but our project partners do to create the input to our software (which uses DSS & DD4J). So I assume they would be happy about a release, but I don't know how urgent.

Xades stuff will btw. be deprecated and most likely removed...

Can I ask why? Because Peppol does not use it, and pd-asic is mostly used in the Peppol world?

(DD4J does not support CAdES based ASiC containers, this is why we integrated DSS directly to support it. It seems DSS it the only way to support both CAdES and XAdES based containers now ...)

phax commented 4 years ago