No error handling? - Githubissues

phaxio / phaxio-ruby

Ruby Gem for Phaxio API

http://bit.ly/phaxio-gem

MIT License

21 stars 34 forks source link

No error handling? #30

Open virusman opened 3 years ago

virusman commented 3 years ago

Is there any kind of error handling? i.e. when sending faxes with invalid phone numbers or other data, the API call would return the error message in previous versions of this gem. However, now it seems like it can only return a Reference with id or throw an unclear error, if anything goes wrong:

undefined method `start_with?' for nil:NilClass

yujideveloper commented 1 year ago

@virusman This is same as #24, and fixed in #43.

ChrisCPO commented 2 weeks ago

@yujideveloper Is there a change log we can follow? We just experienced this I noticed we are a version behind, I did not see a change log to check if this error was fixed.

yujideveloper commented 2 days ago

@ChrisCPO Sorry, I don't know. This issue was fixed at v2.1.1. But v2.1.1 is not tagged on this repo and it is not provided changelog. You can see the changes below: https://my.diffend.io/gems/phaxio/2.1.0/2.1.1 https://github.com/phaxio/phaxio-ruby/compare/v2.1.0...d3a3ad0efdbbfa79f4d9055959741efc205564e7