phaxio / phaxio-ruby

Ruby Gem for Phaxio API
http://bit.ly/phaxio-gem
MIT License
21 stars 34 forks source link

Relax Faraday dependency to a range of versions #31

Closed lucaong closed 3 years ago

lucaong commented 3 years ago

Faraday was updated to version 1.0.0. Currently, phaxio-ruby requires version ~> 0.10. Unfortunately, this conflicts with many popular gems (one example being sentry-ruby) that require at least 1.0.0. In general, Faraday is a very popular gem, so it makes sense to relax the dependency as much as possible.

This PR relaxes the Faraday version to allow both 0.10.x and 1.x.y.

Note that there is already another PR that does something similar, but I believe that the present one introduces a better requirement: the other PR requires ~> 0.10, >= 1.0.1, which would not include 1.0.0, nor 0.11, but would include for example a future 2.0.0 version, which might include breaking changes. This PR instead restricts the semantic version to the ones known to work, namely anything from 0.10 to 1.x.y included, but no more.