phayes / geoPHP

Advanced geometry operations in PHP
https://geophp.net
Other
861 stars 262 forks source link

Forks #196

Open sabas opened 1 year ago

sabas commented 1 year ago

Hello, I just wanted to ping the recent forks and see if all the contributions can be merged back to this original repository or moved to a single fork.. @BathoryPeter @wgirhad @itamair @phayes

What do you think?

wgirhad commented 1 year ago

One of the goals of my fork is to merge the contributions from all these other forks. Next I'd refactor the codebase to support the currently supported PHP versions and the latest PHPUnit. And then try to submit back to @phayes (if he's still interested in this project of course). Actually I didn't try to reach all the authors like you did, but I do fully support your idea.

Thanks for the initiative @sabas

sabas commented 1 year ago

@wgirhad thanks to you, I downloaded your fork via Packagist in the meantime. I hope that we can get to a single fork in case, the one you based on was restructured to be PSR complaint so that's a good start!

sabas commented 1 year ago

I found also this library https://github.com/mjaschen/phpgeo which has different functions for calculations but doesn't have the adapters which geophp have

wgirhad commented 1 year ago

It seem very well documented and actively developed, but in my use case I really need the OpenGIS implementation, because I have a lib that applies a lossy compression on LineStrings (It's still lacking proper documentation though).

With geoPHP I can serialize it back to geoJSON and/or persist it back into a relational database.

sabas commented 1 year ago

@wgirhad I was looking at OpenGIS compatibility as well as I have data from a sql server and output to geojson, perhaps we could discuss an approach by email? I sent you one few days ago :)

itamair commented 1 year ago

thanks ... this looks a nice ideal scenario, but not confident so easily accomplishable, because the all dependencies generated by this original library and all his forks. For what concerns my point of view, as official maintainer of the Drupal geofield module (with thousands of adoptions, along with its dependant geofield map and leaflet) the following are still true:

sabas commented 1 year ago

@itamair What are the functions you need?

I found also this abandoned library and refactored because it had the SimpleFeatures specification (two tests are failing and I didn't succeed in understanding why currently) https://github.com/pdeffendol/geophp

https://github.com/sabas/GeograPHP

I mostly need to do some geometry operations (distances) and output geojson. So probably I will add as dependencies mjaschen/phpgeo and https://github.com/jmikola/geojson

acorncom commented 1 year ago

I've been using https://github.com/Yermo/geoPHPwithFeatures on a project as well that handles features and has some tests